Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

set default statement size for dumpling #160

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

If the user doesn't set statement-size, the dumped statement in the SQL file might be really huge.

What is changed and how it works?

set default statement-size to 1000000

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

@lichunzhu
Copy link
Contributor Author

cc @lance6716

@lance6716
Copy link
Collaborator

LGTM

@lichunzhu lichunzhu merged commit d00c8ed into pingcap:master Oct 2, 2020
@lichunzhu lichunzhu deleted the setDefaultStatementSize branch October 2, 2020 06:26
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* set default statement size for dumpling
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* set default statement size for dumpling
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* set default statement size for dumpling
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* set default statement size for dumpling
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants