Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

filter: refine system database filter rule #194

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Nov 9, 2020

What problem does this PR solve?

close #193

What is changed and how it works?

excluding system databases for both TiDB and MySQL. Users can reset --filter argument to dump system databases.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Exclude system databases in --filter parameter by default.

v4/export/config.go Outdated Show resolved Hide resolved
@kennytm kennytm added the status/LGT1 One reviewer approved (LGTM1) label Nov 9, 2020
@kennytm kennytm merged commit 7633719 into pingcap:master Nov 9, 2020
@lichunzhu lichunzhu deleted the refineFilter branch November 9, 2020 09:04
lichunzhu added a commit to lichunzhu/dumpling that referenced this pull request Nov 9, 2020
kennytm pushed a commit that referenced this pull request Nov 9, 2020
* hotfix the bug that -T can't work which is introduced from #194

* use sameStringArray
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
…mpling#194 (pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap/dumpling#194

* use sameStringArray
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT1 One reviewer approved (LGTM1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Dumpling to export MySQL and TiDB schema is inconsistent
2 participants