-
Notifications
You must be signed in to change notification settings - Fork 85
export: don't +1 TSO when set GC safepoint (#290) #302
export: don't +1 TSO when set GC safepoint (#290) #302
Conversation
/merge |
@lichunzhu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9a6fc26
|
This is an automated cherry-pick of #290
What problem does this PR solve?
this error is hard to reproduce, so I added a 10 minutes sleep before any dump indeed occurs. The error may be sliently different but I think the root cause is same . Here's the log
What is changed and how it works?
as title
Check List
Tests
Side effects
Related changes
Release note