Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explain support for CHbenchmark #164

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Add explain support for CHbenchmark #164

merged 1 commit into from
Mar 29, 2023

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Mar 29, 2023 •
edited
Loading

  1. Support --use-explain for CHbenchmark.
  2. Always drain the result by calling rows.Next() and then report the duration. Otherwise the reported CHbenchmark query time may be inaccurate sometimes.
  3. Use logger to output stderr to avoid interleaving results.

@breezewish
Add explain support for CHbenchmark
a65f65c 
Signed-off-by: Wish <breezewish@outlook.com>
@dbsid dbsid merged commit 0c29c49 into pingcap:master Mar 29, 2023
@breezewish breezewish deleted the ch-explain branch March 29, 2023 08:26
@Yui-Song Yui-Song mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbsid dbsid dbsid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breezewish @dbsid