Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSV output #256

Merged
merged 23 commits into from
Oct 21, 2022
Merged

Add CSV output #256

merged 23 commits into from
Oct 21, 2022

Conversation

jeffa5
Copy link

@jeffa5 jeffa5 commented Oct 19, 2022

  • Record start time in measurements
  • Adds the CSV measurement type
  • Adds configurable writing to file for measurements
  • Rework measurement reporting to be handled inside the measurement type (histograms output different structure to csv)
    • This removes the Info and Summary methods providing a simpler interface
  • Add output configuration section to README

Fixes #255

Andrew Jeffery added 22 commits October 18, 2022 16:38
zyguan
zyguan reviewed Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

pkg/measurement/measurement.go Show resolved Hide resolved
zyguan
zyguan approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyguan zyguan merged commit 4d727a7 into pingcap:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyguan zyguan zyguan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for raw measurement data
2 participants
@jeffa5 @zyguan