Push down precondition to TiKV #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
|
@disksing @MyonKeminta PTAL |
2 tasks
disksing
reviewed
Jan 21, 2019
| message KeyError { | ||
| LockInfo locked = 1; // Client should backoff or cleanup the lock then retry. | ||
| string retryable = 2; // Client may restart the txn. e.g write conflict. | ||
| string abort = 3; // Client should abort the txn. | ||
| WriteConflict conflict = 4; // Write conflict is moved from retryable to here. | ||
| AlreadyExist already_exist = 5; // Key already exists |
There was a problem hiding this comment.
No error code for the case that equal_to not satisfied?
There was a problem hiding this comment.
Currently we only use should_not_exist.
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
disksing
previously approved these changes
Jan 21, 2019
MyonKeminta
reviewed
Jan 21, 2019
| bytes key = 1; | ||
| } | ||
|
|
||
| message NotEqualTo { |
There was a problem hiding this comment.
How about just NotEqual or NotMatch?
There was a problem hiding this comment.
I prefer NotEqualTo, it's more clear.
proto/kvrpcpb.proto
Outdated
| message NotEqualTo { | ||
| bytes key = 1; | ||
| bytes value = 2; | ||
| bytes should_equal_to = 3; |
There was a problem hiding this comment.
How about something like expected_value?
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
disksing
approved these changes
Jan 21, 2019
BusyJay
pushed a commit
to BusyJay/kvproto
that referenced
this pull request
Jan 25, 2019
sticnarf
pushed a commit
to sticnarf/kvproto
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push down precondition to TiKV, so for INSERT statement with unique constraint, the batch_get is not necessary any more.