errorpb: rename StaleEpoch to EpochNotMatch #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
BusyJay
previously approved these changes
Jan 24, 2019
proto/errorpb.proto
Outdated
| repeated metapb.Region new_regions = 1; | ||
| message EpochNotMatch { | ||
| repeated metapb.Region current_regions = 1; | ||
| bool is_stale = 2; |
There was a problem hiding this comment.
I think the default value is false, and this may cause some compatible issues?
|
is it backward compatibility? |
|
Yes, it is. |
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
BusyJay
approved these changes
Jan 25, 2019
MyonKeminta
approved these changes
Jan 31, 2019
overvenus
added a commit
that referenced
this pull request
Feb 26, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
sticnarf
pushed a commit
to sticnarf/kvproto
that referenced
this pull request
Oct 27, 2019
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
StaleEpochtoEpochNotMatchand adds a flag to tell if epoch is stale.