-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kvproto for optimizing assertion for pessimistic transactions #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-assertion-fail
…d-assertion-fail
MyonKeminta
changed the title
[DNM] Update kvproto for implementing assertion
[DNM] Update kvproto for optimizing assertion for pessimistic transactions
Oct 19, 2021
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
1 task
MyonKeminta
changed the title
[DNM] Update kvproto for optimizing assertion for pessimistic transactions
Update kvproto for optimizing assertion for pessimistic transactions
Nov 30, 2021
…d-assertion-fail
ekexium
approved these changes
Nov 30, 2021
Co-authored-by: Ziqian Qin <ekexium@gmail.com>
cfzjywxk
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/merge |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #815 , which is part of pingcap/tidb#26833 .
Since there need to be some adjustments to the design, the kvproto still needs updating. And thus this PR is still not suggested too quickly...
I think it's not a problem to submit a PR that is not ready to merge yet, since the PR can be a tool for tracking progress.