Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kvproto for optimizing assertion for pessimistic transactions #824

Merged
merged 12 commits into from
Dec 2, 2021

Conversation

MyonKeminta
Copy link
Contributor

This continues #815 , which is part of pingcap/tidb#26833 .

Since there need to be some adjustments to the design, the kvproto still needs updating. And thus this PR is still not suggested too quickly...
I think it's not a problem to submit a PR that is not ready to merge yet, since the PR can be a tool for tracking progress.

@MyonKeminta MyonKeminta changed the title [DNM] Update kvproto for implementing assertion [DNM] Update kvproto for optimizing assertion for pessimistic transactions Oct 19, 2021
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta MyonKeminta marked this pull request as draft November 18, 2021 07:56
@MyonKeminta MyonKeminta changed the title [DNM] Update kvproto for optimizing assertion for pessimistic transactions Update kvproto for optimizing assertion for pessimistic transactions Nov 30, 2021
@MyonKeminta MyonKeminta marked this pull request as ready for review November 30, 2021 06:39
proto/kvrpcpb.proto Outdated Show resolved Hide resolved
proto/kvrpcpb.proto Outdated Show resolved Hide resolved
MyonKeminta and others added 2 commits November 30, 2021 16:20
Co-authored-by: Ziqian Qin <ekexium@gmail.com>
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfzjywxk
Copy link
Contributor

/merge

@MyonKeminta
Copy link
Contributor Author

/merge

@MyonKeminta MyonKeminta merged commit a412f7a into pingcap:master Dec 2, 2021
@MyonKeminta MyonKeminta deleted the m/add-assertion-fail branch December 2, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants