Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add splitAndScatterRegions in pdpb.proto #826

Merged
merged 5 commits into from
Nov 3, 2021

Conversation

hzh0425
Copy link
Contributor

@hzh0425 hzh0425 commented Oct 20, 2021

this pr is a child task in issue: tikv/pd#4224

add a method SplitAndScatterRegions in pdpb.proto

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2021

CLA assistant check
All committers have signed the CLA.

Yisaer
Yisaer previously approved these changes Oct 21, 2021
@Yisaer Yisaer dismissed their stale review October 21, 2021 05:11

need change

proto/pdpb.proto Outdated
Comment on lines 682 to 687
message SplitAndScatterRegionsRequest {
RequestHeader header = 1;
repeated bytes split_keys = 2;
string group = 3;
uint64 retry_limit = 4;
}
Copy link
Contributor

@Yisaer Yisaer Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a switch to control whether wait scatter finish like tidb_wait_split_region_finish

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! thanks

@Yisaer
Copy link
Contributor

Yisaer commented Nov 3, 2021

/merge

@disksing disksing merged commit 178a788 into pingcap:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants