-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: add autoid cache option (#765) #806
Conversation
8956307
to
7dd797d
Compare
Codecov Report
@@ Coverage Diff @@
## release-3.1 #806 +/- ##
===============================================
- Coverage 64.57% 64.55% -0.02%
===============================================
Files 33 33
Lines 11438 11444 +6
===============================================
+ Hits 7386 7388 +2
- Misses 3628 3632 +4
Partials 424 424 |
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
should the fail be reasonable in build-integration at branch 3.1? @kennytm |
@AilinKid dunno, but doesn't look like this PR's fault.
|
fcd6076
to
02bf592
Compare
auto_id_cache support, PTAL @tangenta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
cherry-pick auto_id_cache #765 to release 3.1
What is changed and how it works?
Check List
Tests