Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add autoid cache option (#765) #806

Merged
merged 4 commits into from
Apr 22, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Apr 11, 2020

What problem does this PR solve?

cherry-pick auto_id_cache #765 to release 3.1

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@AilinKid AilinKid requested review from bb7133 and removed request for lzmhhh123 April 11, 2020 04:05
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #806 into release-3.1 will decrease coverage by 0.01%.
The diff coverage is 80.85%.

@@               Coverage Diff               @@
##           release-3.1     #806      +/-   ##
===============================================
- Coverage        64.57%   64.55%   -0.02%     
===============================================
  Files               33       33              
  Lines            11438    11444       +6     
===============================================
+ Hits              7386     7388       +2     
- Misses            3628     3632       +4     
  Partials           424      424              

@AilinKid
Copy link
Contributor Author

/build

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor Author

AilinKid commented Apr 13, 2020

should the fail be reasonable in build-integration at branch 3.1? @kennytm

@kennytm
Copy link
Contributor

kennytm commented Apr 13, 2020

@AilinKid dunno, but doesn't look like this PR's fault.

FAIL: integration_test.go:2131: testIntegrationSuite.TestBuiltin

integration_test.go:2478:
    result.Check(testkit.Rows("2016-01-01 08:00:00.0000"))
/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:61:
    res.c.Assert(resBuff.String(), check.Equals, needBuff.String(), res.comment)
... obtained string = "[2016-01-01 00:00:00.0000]\n"
... expected string = "[2016-01-01 08:00:00.0000]\n"
... sql:select from_unixtime(14516064000/10), args:[]

----------------------------------------------------------------------
FAIL: builtin_time_test.go:1143: testEvaluatorSuite.TestFromUnixTime

builtin_time_test.go:1190:
    c.Assert(ans.String(), Equals, t.expect, Commentf("%+v", t))
... obtained string = "2016-01-01 00:00:00"
... expected string = "2016-01-01 08:00:00"
... {isDecimal:false integralPart:1451606400 fractionalPart:0 decimal:0 format: expect:2016-01-01 08:00:00}

@kennytm kennytm added the status/LGT1 LGT1 label Apr 13, 2020
@AilinKid AilinKid added the status/LGT2 LGT2 label Apr 13, 2020
@AilinKid
Copy link
Contributor Author

auto_id_cache support, PTAL @tangenta

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta removed the status/LGT1 LGT1 label Apr 22, 2020
@AilinKid AilinKid merged commit 6828a0a into pingcap:release-3.1 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants