Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add autoid cache option (#765) #807

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

cherry-pick auto_id_cache #765 to release 3.0

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #807 into release-3.0 will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release-3.0     #807      +/-   ##
===============================================
- Coverage        64.48%   64.46%   -0.02%     
===============================================
  Files               31       31              
  Lines            10991    10997       +6     
===============================================
+ Hits              7087     7089       +2     
- Misses            3495     3499       +4     
  Partials           409      409              

@AilinKid
Copy link
Contributor Author

/run-build-integration

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor Author

AilinKid commented Apr 13, 2020

Same here, should the fail be reasonable in build-integration at branch 3.0? @kennytm

@kennytm kennytm added the status/LGT1 LGT1 label Apr 13, 2020
tangenta
tangenta previously approved these changes Apr 22, 2020
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link

sre-bot commented Apr 27, 2020

/run-all-tests

@AilinKid
Copy link
Contributor Author

build-integration seems none of this PR's business.

@sre-bot
Copy link

sre-bot commented Apr 27, 2020

@AilinKid merge failed.

@AilinKid AilinKid merged commit 13aa55e into pingcap:release-3.0 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants