parser: add order by clause in group_concat (#813) #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## release-4.0 #849 +/- ##
===============================================
- Coverage 78.24% 78.23% -0.01%
===============================================
Files 40 40
Lines 14706 14718 +12
===============================================
+ Hits 11507 11515 +8
- Misses 2519 2521 +2
- Partials 680 682 +2 |
|
build-integration fails because of pingcap/tidb#17013 |
kennytm
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #813
What problem does this PR solve?
part of pingcap/tidb#6838
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes