Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: support internal proxy (#2508) #2511

Merged
merged 5 commits into from
Jun 5, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 5, 2020

cherry-pick #2508 to release-4.0


Signed-off-by: Zheng Xiangsheng hundundm@gmail.com

What problem does this PR solve?

realize #532 Each pd can handle dashboard front-end resource requests

What is changed and how it works?

  • config: add Dashboard.InternalProxy config
  • dashboard: support internal proxy

Check List

Tests

  • Unit test

Code changes

  • Has configuration change

Related changes

Release note

  • The built-in dashboard supports internal proxy.

Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
@HunDunDM
Copy link
Member

HunDunDM commented Jun 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 5, 2020

Your auto merge job has been accepted, waiting for:

  • 2509

@codecov-commenter
Copy link

Codecov Report

Merging #2511 into release-4.0 will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-4.0    #2511   +/-   ##
============================================
  Coverage        76.99%   76.99%           
============================================
  Files              204      204           
  Lines            21864    21878   +14     
============================================
+ Hits             16834    16846   +12     
- Misses            3737     3747   +10     
+ Partials          1293     1285    -8     
Impacted Files Coverage Δ
server/config/config.go 78.00% <ø> (ø)
pkg/dashboard/adapter/adapter.go 70.00% <84.61%> (ø)
pkg/dashboard/dashboard.go 90.69% <90.32%> (+2.46%) ⬆️
pkg/dashboard/adapter/redirector.go 94.23% <100.00%> (+0.61%) ⬆️
pkg/dashboard/uiserver/embedded_assets_rewriter.go 100.00% <100.00%> (ø)
tests/cluster.go 86.74% <100.00%> (ø)
server/schedulers/shuffle_hot_region.go 63.47% <0.00%> (-11.31%) ⬇️
server/region_syncer/client.go 81.67% <0.00%> (-4.59%) ⬇️
pkg/btree/btree.go 86.84% <0.00%> (-0.81%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f1c69...e9d8ff4. Read the comment docs.

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit bbf1354 into tikv:release-4.0 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants