dashboard: support internal proxy #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
HunDunDM
requested review from
rleungx and
breezewish
and removed request for
rleungx
HunDunDM
added
the
needs-cherry-pick-release-4.0
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #2508 +/- ##
==========================================
+ Coverage 77.10% 77.30% +0.19%
==========================================
Files 204 204
Lines 21988 22002 +14
==========================================
+ Hits 16954 17008 +54
+ Misses 3749 3722 -27
+ Partials 1285 1272 -13
Continue to review full report at Codecov.
|
rleungx
approved these changes
Jun 5, 2020
breezewish
approved these changes
Jun 5, 2020
|
/merge |
1 similar comment
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #2511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zheng Xiangsheng hundundm@gmail.com
What problem does this PR solve?
realize #532 Each pd can handle dashboard front-end resource requests
What is changed and how it works?
Dashboard.InternalProxyconfigCheck List
Tests
Code changes
Related changes
pingcap/docs/pingcap/docs-cn:Release note