Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binlog.json add TSO info & grafana alert rule #1035

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

buggithubs
Copy link
Contributor

@buggithubs buggithubs commented Feb 4, 2021

What problem does this PR solve?

What is changed and how it works?

image

Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

  • No release note

@sre-bot
Copy link

sre-bot commented Feb 4, 2021

@3pointer
Copy link
Contributor

3pointer commented Feb 4, 2021

/run-all-tests

1 similar comment
@3pointer
Copy link
Contributor

3pointer commented Feb 4, 2021

/run-all-tests

@3pointer
Copy link
Contributor

3pointer commented Feb 4, 2021

/run-all-tests

@3pointer
Copy link
Contributor

3pointer commented Feb 4, 2021

/rebuild

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants