drainer: fix too much version when initializing table infos #1237
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
/merge /run-integration-tests |
|
@lichunzhu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| @@ -122,7 +122,7 @@ type SyncerConfig struct { | |||
| EnableCausalityFlag *bool `toml:"-" json:"enable-detect-flag"` | |||
| DisableCausalityFile *bool `toml:"disable-detect" json:"disable-detect"` | |||
| EnableCausalityFile *bool `toml:"enable-detect" json:"enable-detect"` | |||
| LoadTableInfos bool `toml:"load-table-infos" json:"load-table-infos"` | |||
| LoadSchemaSnapshot bool `toml:"load-schema-snapshot" json:"load-schema-snapshot"` | |||
There was a problem hiding this comment.
in-compatible change? might need tell customer about this if they uses old parameter
There was a problem hiding this comment.
this parameter is never released. I have discussed with frank before and forget to change this.
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 917c39c
|
|
/cherry-pick master |
|
/cherry-pick release-6.5 |
|
/run-integration-tests |
|
@lichunzhu: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@lichunzhu: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #1137
What is changed and how it works?
switch create table to batch create table to solve too many versions problem.
Check List
Tests
Code changes
Side effects
Related changes
Release note