Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sequence iterator and BinlogGenrator #538

Merged
merged 9 commits into from
Apr 16, 2019
Merged

Add sequence iterator and BinlogGenrator #538

merged 9 commits into from
Apr 16, 2019

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

part of #532

What is changed and how it works?

  • pkg/loader: Add sql mode support and ok to set part of metrics
  • Add sequenceIterator.go: a helper to iterate row event by sequence
  • add testing.go: BinlogGenrator for test(may be use by other pkg too), besides BinlogGenrator, other code about test just moved from other file.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

@sre-bot
Copy link

sre-bot commented Apr 13, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

suzaku
suzaku reviewed Apr 15, 2019
View reviewed changes
drainer/translator/sequence_iterator.go Outdated Show resolved Hide resolved
drainer/translator/testing.go Outdated Show resolved Hide resolved
@july2993
Copy link
Contributor Author

/rebuild

@july2993
Copy link
Contributor Author

@suzaku PTAL

@suzaku
Copy link
Contributor

suzaku commented Apr 15, 2019

/run-unit-tests

suzaku
suzaku reviewed Apr 15, 2019
View reviewed changes
drainer/translator/testing.go Show resolved Hide resolved
pkg/loader/util.go Outdated Show resolved Hide resolved
@july2993
Copy link
Contributor Author

/run-all-tests

@july2993
Copy link
Contributor Author

/rebuild

@suzaku
Copy link
Contributor

suzaku commented Apr 16, 2019

LGTM

@july2993 july2993 requested a review from kennytm April 16, 2019 09:48
kennytm
kennytm reviewed Apr 16, 2019
View reviewed changes
drainer/translator/sequence_iterator_test.go Outdated Show resolved Hide resolved
drainer/translator/testing.go Show resolved Hide resolved
drainer/translator/testing.go Show resolved Hide resolved
drainer/translator/translator.go Outdated Show resolved Hide resolved
pkg/loader/util.go Outdated Show resolved Hide resolved
july2993 and others added 2 commits April 16, 2019 19:09
@july2993
remove dsn
f6e3d21
@kennytm @july2993
Apply suggestions from code review
5358532 
Co-Authored-By: july2993 <july2993@gmail.com>
@july2993 july2993 requested a review from kennytm April 16, 2019 11:25
@july2993 july2993 merged commit 4e45ea9 into master Apr 16, 2019
@july2993 july2993 deleted the hjh/drainer1 branch April 16, 2019 12:12
@july2993 july2993 mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzaku suzaku suzaku left review comments

@kennytm kennytm kennytm approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@july2993 @sre-bot @suzaku @kennytm