drainer: remove pb compress config && change 'pb' to 'file' #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
suzaku
reviewed
Apr 24, 2019
drainer/config.go
Outdated
| @@ -197,7 +197,7 @@ func (cfg *Config) Parse(args []string) error { | |||
| } | |||
|
|
|||
| func (c *SyncerConfig) adjustWorkCount() { | |||
| if c.DestDBType == "pb" || c.DestDBType == "kafka" { | |||
| if c.DestDBType == "pb" || c.DestDBType == "file" || c.DestDBType == "kafka" { | |||
There was a problem hiding this comment.
How about replacing pb with file in (cfg *Config).adjustConfig and only handle the file type in the rest of the source code?
There was a problem hiding this comment.
done in 0768e96, PTAL again
IANTHEREAL
reviewed
Apr 24, 2019
| @@ -20,7 +20,7 @@ Usage of drainer: | |||
| -data-dir string | |||
| drainer data directory path (default data.drainer) (default "data.drainer") | |||
| -dest-db-type string | |||
| target db type: mysql or pb; see syncer section in conf/drainer.toml (default "mysql") | |||
| target db type: mysql or tidb or file or kafka; see syncer section in conf/drainer.toml (default "mysql") | |||
There was a problem hiding this comment.
I think file's OK, better than pb for an end user.
|
LGTM |
suzaku
reviewed
Apr 24, 2019
|
/run-all-tests |
|
/run-all-tests |
…db-binlog into xiang/remove_compress
|
/run-all-tests |
july2993
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
https://internal.pingcap.net/jira/browse/TOOL-1112
Check List
Tests
Related changes