Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pump: Fix pump server start process #709

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Pump: Fix pump server start process #709

merged 2 commits into from
Aug 12, 2019

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

pump server start process:

  1. register the node in pd
    ....
    n. listen ports(http and grpc service)

This leads to pump client maybe find an inaccessible pump server in pd(not listen ports yet)

What is changed and how it works?

change the pump server start process: first, listen ports and then register the node

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@zier-one
Copy link
Contributor Author

PTAL @suzaku @july2993

suzaku
suzaku reviewed Aug 12, 2019
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor

/run-all-tests

1 similar comment
@zyxbest
Copy link
Contributor

zyxbest commented Aug 12, 2019

/run-all-tests

july2993
july2993 approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit 976e256 into pingcap:master Aug 12, 2019
@zier-one zier-one deleted the jira_tool_1470 branch August 12, 2019 11:34
zier-one pushed a commit to zier-one/tidb-binlog that referenced this pull request Aug 15, 2019
fix pump init order, register the node after listen ports (pingcap#709)
e47fb15
@zier-one zier-one mentioned this pull request Aug 15, 2019
Merged
july2993 pushed a commit that referenced this pull request Aug 16, 2019
@july2993
fix pump init order, register the node after listen ports (#709) (#716)
2996270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzaku suzaku suzaku left review comments

@july2993 july2993 july2993 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.1 status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zier-one @july2993 @zyxbest @suzaku