Bug fix: a DDL p-binlog will be ignored when the c-binlog queried from TiKV #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a test case that could reproduce the bug? |
fine |
|
/run-all-tests |
Closed
zier-one
force-pushed
the
fix_ddl_bug
branch
from
002d884
to
eef1a01
Compare
july2993
approved these changes
Dec 19, 2019
|
/run-all-tests |
|
cherry pick to release-3.1 in PR #854 |
|
cherry pick to release-2.1 failed |
july2993
pushed a commit
that referenced
this pull request
Dec 20, 2019
july2993
pushed a commit
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The DDL
c-binlogs sent from TiDB includeddl query,ddl job id. But thec-binlogqueried from TiKV doesn't include this info. Unfortunately, pump never read theddl query,ddl job idfromp-binlog. So a DDLp-binlogwill be ignored when the c-binlog queried from TiKV.fix: #851
What is changed and how it works?
Copy the
ddl query,ddl job idfromp-binlogtoc-binlog.Check List
Tests