Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: refine handle errors #602

Closed
wants to merge 1 commit into from
Closed

ui: refine handle errors #602

wants to merge 1 commit into from

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jun 4, 2020 •
edited
Loading

What did:

  • Use key for the message box to avoid multiple same message boxes

  • Only show the first error if has multiple errors

  • Show "Network Error" in the Alert component as well

    企业微信20200604045627

    企业微信20200604045943

TODO:

@baurine baurine mentioned this pull request Jun 19, 2020
Merged
@baurine baurine mentioned this pull request Jun 30, 2020
Merged
@baurine
Copy link
Collaborator Author

baurine commented Jun 30, 2020 •
edited
Loading

Close this PR since it is replaced by PR #662, and this branch can be deleted.

@baurine baurine closed this Jun 30, 2020
@breezewish breezewish deleted the refine-error branch June 30, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baurine @breezewish