Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remember the selected legends for metric chart #663

Merged
merged 4 commits into from
Jul 6, 2020
Merged

remember the selected legends for metric chart #663

merged 4 commits into from
Jul 6, 2020

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jun 30, 2020 •
edited
Loading

close #598

Before:

6

After:

19

  • TODO: fix the new warning when toggling the legend

image

@baurine baurine marked this pull request as draft June 30, 2020 09:42
@baurine baurine mentioned this pull request Jul 1, 2020
Closed
@baurine
Copy link
Collaborator Author

baurine commented Jul 1, 2020

After comparing the demo code provided by echarts-for-react, I found the simplest way is just changing the noMerge prop value to its default false, then echarts will keep the old state inside itself. This change won't affect the result.

@baurine baurine marked this pull request as ready for review July 1, 2020 03:59
breezewish
breezewish approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ti-srebot
Copy link

@breeswish,Thanks for your review.

ti-srebot
ti-srebot approved these changes Jul 6, 2020
View reviewed changes
Copy link

@ti-srebot ti-srebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breezewish breezewish merged commit ce91862 into pingcap:master Jul 6, 2020
@baurine baurine deleted the fix-metric-chart branch July 6, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metric chart: hidden item displays again after reloading data
3 participants
@baurine @ti-srebot @breezewish