tweak: add distro infos fallback to keep compatibility #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
breezewish
approved these changes
Aug 6, 2021
|
Is this caused by not using a latest enough PD? |
|
Yes. PD's pr hasn't been merged yet. |
shhdgit
added a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Sep 2, 2021
shhdgit
added a commit
that referenced
this pull request
Sep 2, 2021
* tweak: add fallback to keep compatibility in scenarios without inject distro info (#976) * update: release version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #975
We need a fallback to keep compatibility in scenarios without inject distro info.