Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Replace CSV Ragel parser by a hand-written parser copied from encoding/csv #275

Merged
merged 11 commits into from
Mar 16, 2020
Merged

Replace CSV Ragel parser by a hand-written parser copied from encoding/csv #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3da30cd
mydump: add benchmark for csv parser
kennytm Mar 1, 2020
c7205b5
mydumper: refactor io.Reader + worker.Pool into the same type
kennytm Mar 1, 2020
11e6032
mydumper: change NewCSVParser() to return an interface
kennytm Mar 1, 2020
fa277ed
mydump: replace generated CSV parser by a hand-written CSV parser
kennytm Mar 1, 2020
8de3876
Merge branch 'master' into kennytm/stop-using-ragel-csv-parser
kennytm Mar 11, 2020
423b060
mydump: save the last rows into a sync.Pool
kennytm Mar 11, 2020
3c68786
mydump: addressed comments
kennytm Mar 13, 2020
6ec804c
Merge branch 'master' into kennytm/stop-using-ragel-csv-parser
kennytm Mar 13, 2020
a0529be
mydump: update implementation of ReadUntilTokNewLine()
kennytm Mar 13, 2020
cbcc492
mydump: remove redundant Seek()
kennytm Mar 16, 2020
367fa29
Merge branch 'master' into kennytm/stop-using-ragel-csv-parser
kennytm Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ checksuccess:
$(VFSGENDEV_BIN):
cd tools && $(GOBUILD) -o ../$(VFSGENDEV_BIN) github.com/shurcooL/vfsgen/cmd/vfsgendev

data_parsers: $(VFSGENDEV_BIN) lightning/mydump/parser_generated.go lightning/mydump/csv_parser_generated.go
data_parsers: $(VFSGENDEV_BIN) lightning/mydump/parser_generated.go
PATH="$(GOPATH)/bin":"$(PATH)" protoc -I. -I"$(GOPATH)/src" lightning/checkpoints/file_checkpoints.proto --gogofaster_out=.
$(VFSGENDEV_BIN) -source='"github.com/pingcap/tidb-lightning/lightning/web".Res' && mv res_vfsdata.go lightning/web/

Expand Down
Loading