This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
print lightning log to local file #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
the
status/PTAL
|
|
|
Some printf will affect DM who uses Lightning as a library. |
kennytm
reviewed
May 11, 2020
lightning/config/global.go
Outdated
Comment on lines
181
to
189
| if *logFilePath != "" { | ||
| cfg.App.Config.File = *logFilePath | ||
| } else { | ||
| configFile, err := log.AdjustLogFilePath() | ||
| if err != nil { | ||
| return nil, errors.Annotate(err, "Create debug logs directory failed") | ||
| } | ||
| cfg.App.Config.File = configFile | ||
| fmt.Fprintf(os.Stdout, "Verbose debug logs will be written to %s.\n\n", configFile) |
There was a problem hiding this comment.
there should still be a way to explicitly use stderr as log output.
i suggest using BR's approach of making the default value of the CLI parameter to be the log path.
I move all |
kennytm
reviewed
May 11, 2020
cmd/tidb-lightning/main.go
Outdated
| } else { | ||
| logger.Info("tidb lightning exit") | ||
| fmt.Fprintln(os.Stdout, "tidb lightning exit", err) |
There was a problem hiding this comment.
Suggested change
| fmt.Fprintln(os.Stdout, "tidb lightning exit", err) | |
| fmt.Fprintln(os.Stdout, "tidb lightning exit") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#307
Now lightning print logs directly to console if the user doesn't set log path. The stack info will confuse the users. For example:
What is changed and how it works?
Redirect logs to log file. If it's not given, will save log to
./logs/tidb-lightning-timestamp.log. Only print necessary error message in console.The testing result is:
Check List
Tests
Related changes