Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

post-process: only update auto increment id when needed #348

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jul 14, 2020

What problem does this PR solve?

After pingcap/tidb#18326 tidb won't always create all autoid allocators, so we should only update auto increment count when needed to avoid tidb panic.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Related changes

@glorv glorv requested review from 3pointer and kennytm July 14, 2020 07:07
@glorv glorv changed the title postprocess: only update auto increment id when needed post-process: only update auto increment id when needed Jul 14, 2020
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Jul 14, 2020
@overvenus overvenus merged commit f38aa6e into master Jul 14, 2020
@kennytm kennytm deleted the fix-auto-inc branch July 14, 2020 07:50
@overvenus overvenus added this to the v4.0.3 milestone Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT1 One reviewer already commented LGTM (LGTM1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants