This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
backend/local: add encode for retry scan region keys #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glorv
force-pushed
the
fix-retry-split
branch
3 times, most recently
from
9920914
to
dff08f3
Compare
| regionMap := make(map[uint64]*split.RegionInfo) | ||
| for _, region := range regions { | ||
| regionMap[region.Region.GetId()] = region | ||
| } | ||
|
|
||
| var splitKeyMap map[uint64][][]byte | ||
| if len(retryKeys) > 0 { | ||
| firstKeyEnc := codec.EncodeBytes([]byte{}, retryKeys[0]) | ||
| lastKeyEnc := codec.EncodeBytes([]byte{}, retryKeys[len(retryKeys)-1]) | ||
| if bytes.Compare(firstKeyEnc, regions[0].Region.StartKey) < 0 || !beforeEnd(lastKeyEnc, regions[len(regions)-1].Region.EndKey) { |
There was a problem hiding this comment.
Why compare firstKey and regions[0]?
There was a problem hiding this comment.
fistKey is the smallest key, so it should be included in region[0]; and lastKey in region[-1]
There was a problem hiding this comment.
It seems that region.StartKey without encode can not compare to other encoded key directly?
There was a problem hiding this comment.
|
/run-all-tests |
Signed-off-by: glorv <glorvs@163.com>
glorv
force-pushed
the
fix-retry-split
branch
from
dff08f3
to
372ad80
Compare
|
/run-all-tests |
|
@Little-Wallace, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: migrate(slack). |
glorv
added a commit
that referenced
this pull request
Jan 22, 2021
Signed-off-by: glorv <glorvs@163.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the bug that the retry split key is not encoded, which causes scanned regions are incorrect.
What is changed and how it works?
Check List
Tests
Side effects
Related changes
Release Note