This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
mydumper: do not remove more than 1 sep if trim last sep is true #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/lgtm |
ti-srebot
approved these changes
Dec 29, 2020
ti-srebot
added
the
status/LGT2
|
/merge |
|
/run-all-tests |
|
@glorv merge failed. |
|
/merge |
|
/run-all-tests |
|
@glorv merge failed. |
|
waiting for TiFlash to update version for the master branch |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #532
What is changed and how it works?
Remove only the last sep if
trim-last-sepis trueCheck List
Tests
Side effects
Related changes
Release Note
trim-last-sepis true, which causes "column count mismatch" in tidb backend