stable scheduling: fix bug in reporting assigned nodes of tidb members (

#531)
pingcap · May 29, 2019 · 3a06f1e · 3a06f1e
1 parent f12b599
commit 3a06f1e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/manager/member/tidb_member_manager.go b/pkg/manager/member/tidb_member_manager.go
@@ -389,6 +389,7 @@ func (tmm *tidbMemberManager) syncTidbClusterStatus(tc *v1alpha1.TidbCluster, se
 		oldTidbMember, exist := tc.Status.TiDB.Members[name]
 		if exist {
 			newTidbMember.LastTransitionTime = oldTidbMember.LastTransitionTime
+			newTidbMember.NodeName = oldTidbMember.NodeName
 		}
 		if !exist || oldTidbMember.Health != newTidbMember.Health {
 			newTidbMember.LastTransitionTime = metav1.Now()
@@ -398,10 +399,9 @@ func (tmm *tidbMemberManager) syncTidbClusterStatus(tc *v1alpha1.TidbCluster, se
 			return err
 		}
 		if pod != nil && pod.Spec.NodeName != "" {
-			// Update assiged node
+			// Update assiged node if pod exists and is scheduled
 			newTidbMember.NodeName = pod.Spec.NodeName
 		}
-		// Ignore if pod does not exist or not scheduled
 		tidbStatus[name] = newTidbMember
 	}
 	tc.Status.TiDB.Members = tidbStatus