Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Aylei <rayingecho@gmail.com>
  • Loading branch information
aylei committed Apr 16, 2019
1 parent 2b43106 commit f6bebaf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/tidb-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
externalTrafficPolicy: {{ .Values.tidb.service.externalTrafficPolicy }}
{{- end }}
{{- if .Values.tidb.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.tidb.service.loadBalancerIP }}
loadBalancerIP: {{ .Values.tidb.service.loadBalancerIP }
{{- end }}
ports:
- name: mysql-client
Expand Down
2 changes: 2 additions & 0 deletions docs/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ $ rm -rf /mnt/disks/local-pv01
$ rm -rf /data/local-pv01
```

You should also delete the related entries in `/etc/fstab` at the same time, otherwise the automount may cause problems when the machine restarts.

> Note: The local-volume plugin expects paths to be stable, if you remove a previous mount-point in the discovery directory (default to `/mnt/disks/`), you should remove the PV manually to keep consistency.
## Install TiDB Operator
Expand Down

0 comments on commit f6bebaf

Please sign in to comment.