PD placement rules should be enabled if using TiFlash

[yeya24]

Bug Report

What version of TiDB Operator are you using?

latest release

What did you do?

Start TiDBCluster with TiFlash

What did you expect to see?

TiFlash and TiDBcluster running normally

What did you see instead?

TiFlash failed to start because the PD placement-rules is not enabled, this is a prerequisite for TiFlash. Error log of TiFlash

klo yeya24-tiflash-0 -c proxylog
[2020/04/16 19:27:56.857 +00:00] [ERROR] [util.rs:327] ["request failed"] [err="Grpc(RpcFailure(RpcStatus { status: FailedPrecondition, details: Some(\"placement rules is disabled\") }))"]
[2020/04/16 19:27:56.857 +00:00] [ERROR] [util.rs:327] ["request failed"] [err="Grpc(RpcFailure(RpcStatus { status: FailedPrecondition, details: Some(\"placement rules is disabled\") }))"]
[2020/04/16 19:27:56.857 +00:00] [FATAL] [server.rs:287] ["failed to start node: Other(\"[src/pd/util.rs:335]: fail to request\")"]

PD config status:

pdctl config show | grep enable-placement
    "enable-placement-rules": "false",

If I manually enabled replacement rules in PD, then TiFlash starts perfectly

[DanielZhangQD]

@yeya24 Thanks for reporting this issue, the integration with TiFlash is still in progress, we will enable the placement rules config automatically.

[yeya24]

This can be closed now.

[Yisaer]

I think we could using pdapi to configure placement rule before syncing tiflash instead of setting it in the config.toml in this PR https://github.com/pingcap/tidb-operator/pull/2328/files