Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable placement rules automatically (#2328) #2340

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Enable placement rules automatically (#2328) #2340

merged 2 commits into from
Apr 29, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 29, 2020

cherry-pick #2328 to release-1.1

What problem does this PR solve?

Fix #2219

What is changed and how does it work?

If users enable TiFlash for the existing TiDB Cluster, enable placement rules automatically with pdapi.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Enable TiFlash for the existing TiDB Cluster, enable-placement-rules is set automatically and PD cluster will not be rolling updated.
    • Create cluster with enable-placement-rules set, tiflash will start successfully and the operator will not update the enable-placement-rules config.

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

Set `enable-placement-rules` to `true` for PD if TiFlash is enabled in the cluster

@sre-bot sre-bot mentioned this pull request Apr 29, 2020
Merged
@sre-bot sre-bot requested review from cofyc, weekface and Yisaer April 29, 2020 09:01
@DanielZhangQD DanielZhangQD changed the title do not enable placement rules automatically (#2328) Enable placement rules automatically (#2328) Apr 29, 2020
@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

/run-all-tests

@sre-bot sre-bot merged commit d545aa0 into pingcap:release-1.1 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weekface weekface weekface approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
CanMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @DanielZhangQD @weekface