-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCP: Support the noise reduction for auto-scaling #2241
Comments
/pick-up-challenge |
@TennyZhuang already had picked pingcap/tidb-dashboard#303, pingcap/tidb#15008, tikv/tikv#7223, finish one before pick up a new one. |
/pick-up-challenge |
@zhoudian64 don't have enough score, pick up failed Progress |
/pick-up-challenge |
@vincent178 pick up issue success |
@vincent178 Hi, Is there any progress now? |
@Yisaer yeah, I'm still reading the code, will reach out to you maybe tomorrow or the day after to discuss some details, thanks. |
@vincent178 okay, please contact me through slack personal message if you have any problem or question. I would help you. |
* add ReadyToScaleOut, ReadyToScaleIn status * ensure cluster not auto-scale when upgrade * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
* add ReadyToScaleOut, ReadyToScaleIn status * ensure cluster not auto-scale when upgrade * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
* add ReadyToScaleOut, ReadyToScaleIn status * ensure cluster not auto-scale when upgrade * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
* add ReadyToScaleOut, ReadyToScaleIn status * ensure cluster not auto-scale when upgrade * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
* add ReadyToScaleOut, ReadyToScaleIn status * ensure cluster not auto-scale when upgrade * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
* add ReadyToScaleOut, ReadyToScaleIn status * ensure cluster not auto-scale when upgrade * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
* add ReadyToScaleOut, ReadyToScaleIn status * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
* add ReadyToScaleOut, ReadyToScaleIn status * record ReadyToScaleOut, ReadyToScaleIn timestamp * ensure auto scale happens after cluster status remains ReadyToScaleOut, ReadyToScaleIn for user configured time
Description
Currently, the auto-scaling doesn't have the noise reduction design. It means in each reconciliation in auto-scaling controller, the result would be updated into tidbcluster immediately when the result indicates to scale-out or scale-in.
Now we want to support the noise reduction for auto-scaling and design detailed is designed in following:
For
TidbClusterAutoScaler
, the status would have 3 choices: Normal / ReadyToScaleOut / ReadyToScaleIn.Normal
ReadyToScaleOut
/ReadyToScaleIn
and record the timestamp in annotation.ReadyToScaleOut
/ReadyToScaleIn
for a certain time (which could also be configured in theTidbClusterAutoScaler
spec), the auto-scaling controller would finally updated its result in the tidbcluster.Normal
again.I think the PR for this issue not only contains the logic of the noise reduction but also should have a e2e case to cover it. You could look the previous logic for auto-scaling in e2e here:
tidb-operator/tests/e2e/tidbcluster/serial.go
Line 653 in 5341bab
Score
Mentor(s)
Contact the mentors: #tidb-challenge-program channel in TiDB-Operator Community Slack Workspace
As the logic is not simple and the detail is still needed to be discussed, we are welcome for every challenger to contact the mentor if you have any questions.
Recommended Skills
The text was updated successfully, but these errors were encountered: