Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set --capacity to tikv-server if resources.limits.storage is not given #944

Closed
cofyc opened this issue Sep 24, 2019 · 4 comments
Closed

Comments

@cofyc
Copy link
Contributor

cofyc commented Sep 24, 2019

Feature Request

Is your feature request related to a problem? Please describe:

Currently, we cannot set raftstore.capacity in TiKV configuration.

# Note that we can't set raftstore.capacity in config because it will be overridden by the command line parameter,

Describe the feature you'd like:

Do not pass TiKV default value if resources.limits.storage is absent. This will make it possible for users to set capacity in TiKV configuration.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

xref: #868 #942

@cofyc
Copy link
Contributor Author

cofyc commented Sep 24, 2019

cc @weekface @tennix what do you think?

@cofyc cofyc changed the title Do not set --capacity to tikv-server if resources.limits.capacity is not given Do not set --capacity to tikv-server if resources.limits.storage is not given Sep 24, 2019
@weekface
Copy link
Contributor

It's fine with me.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants