Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values.yaml #868

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Update values.yaml #868

merged 2 commits into from
Sep 3, 2019

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 3, 2019

What problem does this PR solve?

Add note about tikv config to avoid parameters not taking effect

Check List

Tests

  • Unit test

Add note about tikv config to avoid parameters not taking effect
@CLAassistant
Copy link

CLAassistant commented Sep 3, 2019

CLA assistant check
All committers have signed the CLA.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 3, 2019

@onlymellb PTAL

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weekface
Copy link
Contributor

weekface commented Sep 3, 2019

/run-e2e-in-kind

Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants