Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kernel parameters settings in pod security context #1016

Merged
merged 4 commits into from
Oct 16, 2019

Conversation

tennix
Copy link
Member

@tennix tennix commented Oct 15, 2019

What problem does this PR solve?

This PR fixes #924

What is changed and how does it work?

Add some sysctl kernel tuning example configurations to pod security context.

Check List

Tests

  • Manual test

Code changes

  • Has Helm charts change

Side effects

None

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

add some sysctl kernel parameter settings for tuning.

@tennix tennix added the status/PTAL PR needs to be reviewed label Oct 15, 2019
@tennix tennix requested review from weekface, cofyc and aylei October 15, 2019 09:51
cofyc
cofyc previously approved these changes Oct 15, 2019
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix force-pushed the tune-kernel-parameters branch from 11f3578 to 53b797f Compare October 15, 2019 10:11
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Oct 16, 2019

/run-e2e-in-kind

@tennix tennix merged commit 0aa8fa8 into pingcap:master Oct 16, 2019
@tennix tennix deleted the tune-kernel-parameters branch October 16, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/PTAL PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure recommended namespaced kernel parameters by default
4 participants