fix stability test, add v1 to statefulset apiVersions
#1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
force-pushed
the
fix-stability-test
branch
from
c8bb41e to
98428a8
Compare
weekface
force-pushed
the
fix-stability-test
branch
from
98428a8 to
1a8614a
Compare
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
onlymellb
reviewed
Oct 30, 2019
onlymellb
reviewed
Oct 30, 2019
| @@ -447,7 +447,7 @@ func (oa *operatorActions) DeployOperator(info *OperatorConfig) error { | |||
| } | |||
|
|
|||
| // deploy statefulset webhook and configuration to hijack update statefulset opeartion | |||
| cmd = fmt.Sprintf("kubectl apply -f %s/webhook.yaml", oa.manifestPath(info.Tag)) | |||
| cmd = fmt.Sprintf(`sed 's/apiVersions: \["v1beta1"\]/apiVersions: ["v1", "v1beta1"]/' %s/webhook.yaml | kubectl apply -f -`, oa.manifestPath(info.Tag)) | |||
There was a problem hiding this comment.
manifests/webhook.yaml has been modified, so can you omit this operation?
There was a problem hiding this comment.
no, v1.0.1 or prior only has one v1beta1. We must change them too in the stability test case.
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
cofyc
approved these changes
Oct 30, 2019
weekface
added a commit
that referenced
this pull request
Oct 30, 2019
…fulset apiVersions (#1056) * fix stability test, add `v1` to statefulset apiVersions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: