Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #1065: Fix tkctl version does not work when the release name is #1073

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Automated cherry pick of #1065: Fix tkctl version does not work when the release name is #1073

merged 1 commit into from
Oct 31, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Oct 30, 2019

Cherry pick of #1065 on release-1.0.

#1065: Fix tkctl version does not work when the release name is

@aylei
Fix tkctl version does not work when the release name is un-wanted
09d9e00 
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei requested review from tennix and weekface October 30, 2019 01:38
tennix
tennix approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member

tennix commented Oct 31, 2019

/run-e2e-in-kind

@aylei aylei merged commit 1270ca9 into pingcap:release-1.0 Oct 31, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@csuzhangxc
zh, en: fix uninstall command for Helm 3 (#1073)
a69581e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@weekface weekface Awaiting requested review from weekface

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aylei @tennix