Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set podSecuriyContext to nil by default in favor of backward co… #1079

Merged
merged 5 commits into from
Oct 31, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Oct 30, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

#915 introduced a compatibility issue that the tidb-cluster will get rolling-update after the user upgrades tidb-operator and helm chart. This PR fix the compatibility issue.

close #1076

Does this PR introduce a user-facing change?:

Set podSecuriyContext to nil by default

@weekface @cofyc @DanielZhangQD @tennix PTAL

…bility

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei added the type/bug Something isn't working label Oct 30, 2019
@aylei
Copy link
Contributor Author

aylei commented Oct 31, 2019

/run-e2e-in-kind

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Oct 31, 2019

/run-e2e-in-kind

1 similar comment
@aylei
Copy link
Contributor Author

aylei commented Oct 31, 2019

/run-e2e-in-kind

@aylei
Copy link
Contributor Author

aylei commented Oct 31, 2019

/run-e2e-in-kind

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix changed the title Set podSecuriyContext to nil by default in favor of backward compatible Set podSecuriyContext to nil by default in favor of backward co… Oct 31, 2019
@tennix tennix merged commit 02e166e into pingcap:master Oct 31, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 31, 2019

cherry pick to release-1.0 failed

aylei added a commit to aylei/tidb-operator that referenced this pull request Nov 19, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* support slowlog PV config

* update slowlog config docs location

* remove additional content in view log docs

* update code block type

* fix comments

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiKV get rolling-update when upgrade from v1.1.0.alpha.2 t v1.1.0.alpha.3
5 participants