Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #915: Support configuring sysctls for Pods and enable net.* #1175

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Nov 18, 2019

Cherry pick of #915 on release-1.0.

#915: Support configuring sysctls for Pods and enable net.*

Co-Authored-By: weekface <weekface@gmail.com>
weekface
weekface previously approved these changes Nov 18, 2019
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Nov 18, 2019

/run-e2e-in-kind

Services []Service `json:"services,omitempty"`
PVReclaimPolicy corev1.PersistentVolumeReclaimPolicy `json:"pvReclaimPolicy,omitempty"`
Timezone string `json:"timezone,omitempty"`
MaxFailoverCount int32 `json:"maxFailoverCount,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add MaxFailoverCount in TidbCluster?

Copy link
Contributor Author

@aylei aylei Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that's a typo when I fix the merge conflict in TiDBSpec

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei force-pushed the automated-cherry-pick-of-#915-upstream-release-1.0 branch from e4a2a90 to 99c47ba Compare November 18, 2019 12:35
@aylei
Copy link
Contributor Author

aylei commented Nov 18, 2019

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Nov 18, 2019

/run-e2e-in-kind

@aylei aylei merged commit 8f44000 into pingcap:release-1.0 Nov 19, 2019
@aylei aylei added this to the v1.0.4 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants