Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigMapControlInterface and grant configmap privilege #1275

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Dec 3, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

This PR is separated from #1269 , in order to not blocking the development of #1192 #1264 #1263

Does this PR introduce a user-facing change?:

Add the privilege to operate configmap for tidb-controller-manager.

@tennix @weekface @cofyc @Yisaer PTAL

…map for tidb-controller-manager

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei requested review from weekface, cofyc, tennix and Yisaer December 3, 2019 04:30
@aylei
Copy link
Contributor Author

aylei commented Dec 3, 2019

/run-e2e-test

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 435f78b into pingcap:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants