Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TiKV config schema #1306

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Add TiKV config schema #1306

merged 2 commits into from
Dec 9, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Dec 9, 2019

#1264

  • E2E test

Does this PR introduce a user-facing change?:

Add schema for configuration of TiKV.

@tennix @shuijing198799 @weekface @LinuxGit PTAL

config file: https://github.com/pingcap/tidb-operator/pull/1306/files#diff-35ce941397445e52d38814cd717d06d4

aylei added 2 commits December 9, 2019 16:32
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei aylei changed the title Add Tikv config schema Add TiKV config schema Dec 9, 2019
Copy link
Contributor

@shuijing198799 shuijing198799 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LinuxGit LinuxGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Dec 9, 2019

/run-e2e-tests

@aylei aylei merged commit 5a0cea7 into pingcap:master Dec 9, 2019
@aylei aylei mentioned this pull request Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants