sync pd and tikv configmap in controller #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-test |
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-test |
8 tasks
aylei
commented
Dec 13, 2019
| @@ -250,7 +246,7 @@ type PDScheduleConfig struct { | |||
| // MaxStoreDownTime is the max duration after which | |||
| // a store will be considered to be down if it hasn't reported heartbeats. | |||
| // +optional | |||
| MaxStoreDownTime Duration `toml:"max-store-down-time,omitempty" json:"max-store-down-time,omitempty"` | |||
| MaxStoreDownTime string `toml:"max-store-down-time,omitempty" json:"max-store-down-time,omitempty"` | |||
There was a problem hiding this comment.
BurntSushi/toml do not respect MarshalText, use string instead
There was a problem hiding this comment.
BurntSushi/toml seems not maintained anymore...
we can use https://github.com/pelletier/go-toml and implement toml.MarshalTOML() (like MarshalJSON())
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, that's exactly what I've thought.
Actually I've tried go-toml( and naoina/toml), it turns out that go-toml does not support interface{} (necessary for schemaless configuration, e.g. Pump). Also, PD and TiDB uses BurntSushi/toml so there is little verifying work, seems like that BurntSushi/toml is not an ideal but the only choice
|
/run-e2e-test |
weekface
approved these changes
Dec 13, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
What problem does this PR solve?
close #1263
close #1264
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: