-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binding clusterrole system:kube-scheduler to sa tidb-scheduler #1355
Conversation
/run-e2e-test |
xref: #1356 |
hi, tidb-scheduler pod has two components:
So, in addition to bind the the service account of tidb-scheduler to clusterrole |
@cofyc PTAL |
permissions for kube-scheduler can be removed from is it ok to remove non-clusterScoped support? cc @tennix @weekface @aylei |
/run-e2e-test |
/run-e2e-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for you contributions!
cherry pick to release-1.0 failed |
What problem does this PR solve?
#1252
What is changed and how does it work?
Service account tidb-scheduler is bound three roles/clusterroles :
Check List
Tests
Code changes
Side effects
Breaking backward compatibility
Related changes
Need to cherry-pick to the release branch
Need to update the documentation
Does this PR introduce a user-facing change?: