Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add k8s v1.17 support #1410

Merged
merged 4 commits into from
Dec 26, 2019
Merged

ci: add k8s v1.17 support #1410

merged 4 commits into from
Dec 26, 2019

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Dec 25, 2019

What problem does this PR solve?

fixes: #1313 and closes: #1413

What is changed and how does it work?

Check List

Tests

Code changes

  • Has CI related scripts change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

@@ -95,6 +98,9 @@ rules:
- apiGroups: [""]
resources: ["endpoints"]
verbs: ["delete", "get", "patch", "update"]
- apiGroups: ["coordination.k8s.io"]
resources: ["leases"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit permissions on scheduler.schedulerName with resourceNames?

Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor

aylei commented Dec 26, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 813c29f into pingcap:master Dec 26, 2019
@weekface weekface deleted the ci-1-17 branch December 26, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb-operator can't run on k8s v1.17 e2e: test tidb-operator with Kubernetes v1.17
4 participants