fix pd client tls and use table driven tests to cover tls case #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
commented
Dec 31, 2019
| Values: map[string]string{ | ||
| "enableTLSCluster": "true", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
we can add more to cover various configurations of cluster
|
/run-e2e-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for 1414 |
AstroProfundis
previously approved these changes
Dec 31, 2019
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@cofyc merge failed. |
cofyc
dismissed stale reviews from AstroProfundis, Yisaer, and aylei
via
7a0b3e7
cofyc
force-pushed
the
fix1450
branch
2 times, most recently
from
ea46677 to
d9a38d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #1450
What is changed and how does it work?
Check List
Tests