Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some checks from Jenkins job to Github Actions (#1690) #1694

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Move some checks from Jenkins job to Github Actions (#1690) #1694

merged 1 commit into from
Feb 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Feb 13, 2020

cherry-pick #1690 to release-1.1

What problem does this PR solve?

  • run checks via Github Actions
  • don't run checks in Jenkins job (this speeds up the job)

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@sre-bot sre-bot mentioned this pull request Feb 13, 2020
Merged
@sre-bot sre-bot requested review from aylei, weekface and Yisaer February 13, 2020 08:44
@cofyc
Copy link
Contributor

cofyc commented Feb 13, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 13, 2020

Your auto merge job has been accepted, waiting for 1692

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 13, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 13, 2020

@sre-bot merge failed.

@cofyc cofyc merged commit 3496e2d into pingcap:release-1.1 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@weekface weekface weekface approved these changes

@aylei aylei Awaiting requested review from aylei

Assignees
No one assigned
Labels
status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @cofyc @weekface @Yisaer