Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default value of separateSlowLog (#2023) #2024

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 25, 2020

cherry-pick #2023 to release-1.1


What problem does this PR solve?

The default value of separateSlowLog is set to the incorrect value.

What is changed and how does it work?

Set it to the correct value.

Check List

Tests

  • Unit test
  • E2E test

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 25, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 25, 2020

@sre-bot merge failed.

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 25, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 25, 2020

@sre-bot merge failed.

@DanielZhangQD
Copy link
Contributor

/run-e2e-in-kind

1 similar comment
@DanielZhangQD
Copy link
Contributor

/run-e2e-in-kind

@DanielZhangQD DanielZhangQD merged commit 1405f80 into pingcap:release-1.1 Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants