Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to configure custom env for components (#2052) #2058

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Able to configure custom env for components (#2052) #2058

merged 2 commits into from
Mar 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 30, 2020

cherry-pick #2052 to release-1.1

What problem does this PR solve?

fixes #1922

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Able to configure custom env for components.

@sre-bot sre-bot mentioned this pull request Mar 30, 2020
Merged
DanielZhangQD
DanielZhangQD approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc cofyc merged commit 443d198 into pingcap:release-1.1 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@aylei aylei Awaiting requested review from aylei

@LinuxGit LinuxGit Awaiting requested review from LinuxGit

@weekface weekface Awaiting requested review from weekface

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @DanielZhangQD @cofyc