-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set PD Dashboard Config when TLS Client enabled (#2085) #2130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
DanielZhangQD
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@sre-bot merge failed. |
It seems you need to cherry-pick the commit the update the documents by scripts manually. @weekface I0409 08:16:29.052354 27781 main.go:161] written to /home/runner/work/tidb-operator/tidb-operator/go/src/github.com/pingcap/tidb-operator/docs/api-references/docs.md
diffing manifests/crd.yaml with /tmp/tmp.cPgizPntwr
diffing /home/runner/work/tidb-operator/tidb-operator/go/src/github.com/pingcap/tidb-operator/docs/api-references/docs.md with /tmp/tmp.A3thjzcZON
4439a4440,4452
> <tr>
> <td>
> <code>dashboard</code></br>
> <em>
> <a href="#pingcap.com/v1alpha1.DashboardConfig">
> DashboardConfig
> </a>
> </em>
> </td>
> <td>
> <em>(Optional)</em>
> </td>
> </tr>
4885,4897d4897
< </td>
< </tr> |
new pr opened: #2152, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2085 to release-1.1
What problem does this PR solve?
fixes #2078
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: